Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More changes after the calval release #52

Merged
merged 44 commits into from
Jul 28, 2023
Merged

More changes after the calval release #52

merged 44 commits into from
Jul 28, 2023

Conversation

gshiroma
Copy link
Collaborator

@gshiroma gshiroma commented Jun 29, 2023 •
edited
Loading

Changes:

  • Rename static layers product from RTC-S1-SL to RTC-S1-STATIC;
  • Remove rasters X, Y, and Inc from call to topo when creating the layover/shadow mask.
  • Reduce radar grid dimensions when creating static layers.
  • Multiple changes to the metadata.
  • Bug fixes.

seongsujeong
seongsujeong approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the most of the changes in this PR are to deal with the features merged in ISCE3 side. The PR looks good to me.

gshiroma and others added 19 commits July 24, 2023 09:37
@gshiroma
Merge branch 'opera-adt:main' into changes_after_calval_4
98e58f7
@gshiroma
reduce static layers radargrid dimensions
07fa084
@gshiroma
do not create HDF5 or VV pol when output product type is RTC-S1-STATI…
04de372 
…C; save noDataValue=NaN for float data
@gshiroma
refactor file
2d9ae26
@gshiroma
add source_data_access and product_data_access to the runconfig and t…
fd9edce 
…o the product metadata
@gshiroma
substitute CEOS with CEOS_ANALYSIS_READY_DATA
f44a8b6
@gshiroma
add source_data_access and product_data_access to the product metadat…
b180a2a 
…a (2)
@gshiroma
add output_backscatter_expression_convention to the metadata
cdab1c7
@gshiroma
add to the metadata equation to convert backscatter from linear to dB
c4c6cc7
@gshiroma
add to the metadata equation to convert backscatter from linear to dB…
0497265 
… (2)
@gshiroma
add source_data_access and product_data_access to the product metadat…
ef179ba 
…a (3)
@gshiroma
do not force generation of the number of looks; fix closing of datase…
ac89a65 
…ts when flag_process is false
@gshiroma
update Docker lockfile with new ISCE3 version
ea3925d
@gshiroma
update Docker lockfile with new ISCE3 version (2)
b2a3dca
@gshiroma
update Docker lockfile with new ISCE3 version (3)
e063a2f
@gshiroma
update RTC-S1 and RTC-S1-STATIC products to match their product specs…
be70792 
… document
@gshiroma
add snap values to the metadata
c5efc48
@gshiroma
revert changes to the Docker lockfile
be2d6bc
@gshiroma
add prefix inputs_ to metadata inputs fields
b3d6125
@gshiroma gshiroma changed the title More changes after the calval release (WIP) More changes after the calval release Jul 27, 2023
@gshiroma gshiroma mentioned this pull request Jul 27, 2023
Merged
seongsujeong
seongsujeong reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Here are my comments and suggestions - Seongsu

src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/mosaic_geobursts.py Outdated Show resolved Hide resolved
src/rtc/rtc_s1.py Outdated Show resolved Hide resolved
src/rtc/rtc_s1.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/rtc_s1_single_job.py Show resolved Hide resolved
seongsujeong
seongsujeong approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the addressing the comments.
Please rebase the PR #55 after merging this one, so that I can have a better look at the following PR.

@gshiroma gshiroma merged commit 6c4ba41 into opera-adt:main Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seongsujeong seongsujeong seongsujeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gshiroma @seongsujeong